Skip to content

Add tooling to compare reference and updated output#1

Merged
sylveon merged 4 commits into
sylveon:user/sylveon/protected-membersfrom
jonwis:user/jonwis/protected-members
Jul 11, 2023
Merged

Add tooling to compare reference and updated output#1
sylveon merged 4 commits into
sylveon:user/sylveon/protected-membersfrom
jonwis:user/jonwis/protected-members

Conversation

@jonwis

@jonwis jonwis commented Jul 10, 2023

Copy link
Copy Markdown

Here's some scripts to help validate the comparison. I wish cmd.exe had a better built-in text manipulation tool. Powershell makes this easy; routing through "copy + findstr /v" is very slow.

The comparison looks pretty reasonable on the Big Windows metadata.

@sylveon

sylveon commented Jul 11, 2023

Copy link
Copy Markdown
Owner

Looks great! I'd suggest adding .ixx to the prepare_versionless_diffs.cmd tool's list of files, as otherwise it misses modules (the current winrt.ixx + future changes which might add more).

Also I hit a footgun with this: I ran build_protection.cmd without rebuilding the cppwinrt binary first when switching branches - suggest either making the script build cppwinrt.exe or mentioning that pitfall in the README.

@sylveon

sylveon commented Jul 11, 2023

Copy link
Copy Markdown
Owner

Also, I don't think anybody would mind a PowerShell script instead ;)

Jon Wiswall added 3 commits July 11, 2023 13:19
@jonwis

jonwis commented Jul 11, 2023

Copy link
Copy Markdown
Author

Alrighty, done. Powershell and doc update.

@sylveon sylveon merged commit 39cbe93 into sylveon:user/sylveon/protected-members Jul 11, 2023
@jonwis jonwis deleted the user/jonwis/protected-members branch August 17, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants